chore: start cleaning up 3.9 usage from examples #3419
Conversation
Summary of ChangesHello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the Python environment within the project's examples. It systematically removes outdated Python 3.9 configurations and introduces support for newer Python versions, specifically 3.12, 3.13, and 3.14. The changes update default versions and expand the range of supported Python environments, ensuring the examples remain relevant and functional with current Python releases. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request begins the process of removing Python 3.9 from the examples, focusing on the multi_python_versions example. The changes involve updating Bazel configuration files (MODULE.bazel, WORKSPACE, BUILD.bazel) to replace Python 3.9 with newer versions like 3.12, 3.13, and 3.14. The test configurations and requirement lock files are also updated accordingly. The changes are mostly correct and align with the goal of the PR. However, I found a critical issue in examples/multi_python_versions/MODULE.bazel where incorrect requirement lock files are used for the newly added Python versions, which would break bzlmod builds.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
Summary:
There is more to go, but this is a good start remaining of #2704